> -----Original Message-----
> From: Nautiyal, Ankit K <ankit.k.nautiyal@xxxxxxxxx>
> Sent: Thursday, December 22, 2022 12:04 PM
> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Manna, Animesh <animesh.manna@xxxxxxxxx>;
> ville.syrjala@xxxxxxxxxxxxxxx
> Subject: [PATCH] drm/i915/dsb: Remove check for dsb in dsb_commit
>
> The dsb context should be already checked for NULL, before dsb_commit
> gets called. So remove the check for dsb inside dsb_commit.
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx>
Earlier intel_dsb_commit() is called without null checking of dsb context.
Added the same by the following change.
commit b358c3b98813b1557588a11c894b22915251a2ce
Author: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Date: Wed Nov 23 17:26:34 2022 +0200
drm/i915: Make DSB lower level
The current change LGTM.
Reviewed-by: Animesh Manna <animesh.manna@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/display/intel_dsb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c
> b/drivers/gpu/drm/i915/display/intel_dsb.c
> index 3d63c1bf1e4f..ce1f8e0c2cd9 100644
> --- a/drivers/gpu/drm/i915/display/intl_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -228,7 +228,7 @@ void intel_dsb_commit(struct intel_dsb *dsb)
> enum pipe pipe = crtc->pipe;
> u32 tail;
>
> - if (!(dsb && dsb->free_pos))
> + if (!dsb->free_pos)
> return;
>
> if (!intel_dsb_enable_engine(dev_priv, pipe, dsb->id))
> --
> 2.25.1
