> -----Original Message----- > From: Nikula, Jani <jani.nikula@xxxxxxxxx> > Sent: Wednesday, December 14, 2022 2:49 PM > To: Murthy, Arun R <arun.r.murthy@xxxxxxxxx>; intel- > gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: RE: [PATCH 0/7] drm/i915: extract vblank/scanline code to > a separate file > > On Wed, 14 Dec 2022, "Murthy, Arun R" <arun.r.murthy@xxxxxxxxx> wrote: > >> -----Original Message----- > >> From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf > >> Of Jani Nikula > >> Sent: Monday, December 12, 2022 7:59 PM > >> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > >> Cc: Nikula, Jani <jani.nikula@xxxxxxxxx> > >> Subject: [PATCH 0/7] drm/i915: extract vblank/scanline > >> code to a separate file > >> > >> Add new intel_vblank.[ch] and dump a bunch of the vblank/scanline > >> code there. > >> > >> Jani Nikula (7): > >> drm/i915/irq: split out vblank/scanline code to intel_vblank.[ch] > > Can the function naming convention such as i915_get_vblank_counter be > > changed to intel_get_vblank_counter in the same series? > > In this case i915_ is a platform prefix, contrast with > g4x_get_vblank_counter(). > > There's more naming to be sorted out, and I wanted to see what the > response was to this split with the scanline functions being included here > before embarking on doing a bunch of tedious renames. > Just commented to see if these changes are coming in the same series. Understand that its more tedious and will be taken later. Thanks for the clarification. Thanks and Regards, Arun R Murthy -------------------- > BR, > Jani. > > > > > Thanks and Regards, > > Arun R Murthy > > -------------------- > > > >> drm/i915/display: move more scanline functions to intel_vblank.[ch] > >> drm/i915/display: use common function for checking scanline is moving > >> drm/i915/hdmi: abstract scanline range wait into intel_vblank.[ch] > >> drm/i915/vblank: use intel_de_read() > >> drm/i915/vblank: add and use intel_de_read64_2x32() to read vblank > >> counter > >> drm/i915/reg: split out vblank/scanline regs > >> > >> drivers/gpu/drm/i915/Makefile | 1 + > >> drivers/gpu/drm/i915/display/intel_crt.c | 1 + > >> drivers/gpu/drm/i915/display/intel_crtc.c | 1 + > >> drivers/gpu/drm/i915/display/intel_de.h | 7 + > >> drivers/gpu/drm/i915/display/intel_display.c | 54 +-- > >> .../drm/i915/display/intel_display_trace.h | 1 + > >> drivers/gpu/drm/i915/display/intel_hdmi.c | 9 +- > >> drivers/gpu/drm/i915/display/intel_vblank.c | 456 > ++++++++++++++++++ > >> drivers/gpu/drm/i915/display/intel_vblank.h | 24 + > >> .../gpu/drm/i915/display/intel_vblank_regs.h | 42 ++ > >> drivers/gpu/drm/i915/gvt/cmd_parser.c | 1 + > >> drivers/gpu/drm/i915/gvt/display.c | 1 + > >> drivers/gpu/drm/i915/gvt/handlers.c | 1 + > >> drivers/gpu/drm/i915/i915_irq.c | 408 ---------------- > >> drivers/gpu/drm/i915/i915_irq.h | 6 - > >> drivers/gpu/drm/i915/i915_reg.h | 35 -- > >> drivers/gpu/drm/i915/intel_gvt_mmio_table.c | 1 + > >> 17 files changed, 541 insertions(+), 508 deletions(-) create mode > >> 100644 drivers/gpu/drm/i915/display/intel_vblank.c > >> create mode 100644 drivers/gpu/drm/i915/display/intel_vblank.h > >> create mode 100644 drivers/gpu/drm/i915/display/intel_vblank_regs.h > >> > >> -- > >> 2.34.1 > > > > -- > Jani Nikula, Intel Open Source Graphics Center
