Re: [PATCH] drm/i915/selftests: Remove hardcoded value with a macro

[Andrzej Hajda <andrzej.hajda@xxxxxxxxx>]

On 13.12.2022 13:00, Nirmoy Das wrote:
> Use MI_USE_GGTT instead of hardcoded value.
>
> Signed-off-by: Nirmoy Das <nirmoy.das@xxxxxxxxx>
> ---
>   drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c
> index c228fe4aba50..3bef1beec7cb 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c
> @@ -222,7 +222,7 @@ static int gpu_set(struct context *ctx, unsigned long offset, u32 v)
>   	}
>   
>   	if (GRAPHICS_VER(ctx->engine->i915) >= 8) {
> -		*cs++ = MI_STORE_DWORD_IMM_GEN4 | 1 << 22;
> +		*cs++ = MI_STORE_DWORD_IMM_GEN4 | MI_USE_GGTT;

Reviewed-by: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>

Regards
Andrzej

>   		*cs++ = lower_32_bits(i915_ggtt_offset(vma) + offset);
>   		*cs++ = upper_32_bits(i915_ggtt_offset(vma) + offset);
>   		*cs++ = v;