Re: [PATCH v2 02/11] drm/i915/de: return the old register value from intel_de_rmw()

[Andrzej Hajda <andrzej.hajda@xxxxxxxxx>]

On 07.12.2022 18:17, Jani Nikula wrote:
> A similar thing was added in intel_uncore_rmw(). Make it available for
> display too.
>
> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>

Reviewed-by: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>

Regards
Andrzej

> ---
>   drivers/gpu/drm/i915/display/intel_de.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_de.h b/drivers/gpu/drm/i915/display/intel_de.h
> index 004f01906fd7..3dbd76fdabd6 100644
> --- a/drivers/gpu/drm/i915/display/intel_de.h
> +++ b/drivers/gpu/drm/i915/display/intel_de.h
> @@ -34,10 +34,10 @@ intel_de_write(struct drm_i915_private *i915, i915_reg_t reg, u32 val)
>   	intel_uncore_write(&i915->uncore, reg, val);
>   }
>   
> -static inline void
> +static inline u32
>   intel_de_rmw(struct drm_i915_private *i915, i915_reg_t reg, u32 clear, u32 set)
>   {
> -	intel_uncore_rmw(&i915->uncore, reg, clear, set);
> +	return intel_uncore_rmw(&i915->uncore, reg, clear, set);
>   }
>   
>   static inline int