Re: [Intel-gfx 1/6] drm/i915/guc: Fix GuC relay log debugfs failing open

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 06/12/2022 08:32, Tvrtko Ursulin wrote:

On 09/05/2022 22:01, Alan Previn wrote:
When GuC-Error-Capture was introduced, we created
buf_in_use as a way to identify if relay logging
had started. It is meant to replace the previous
method where a mmap of the GuC log buffer was
the indicator but not since GuC Error Capture
shares that mapping throughout operation.

However, that method of checking was not updated
when the debugfs guc_log_relay_ctl_open was called.
Fix that check.

Fixes:
    drm/i915/guc: Add capture region into intel_guc_log
    (daff407a083d).

Wrong format of fixes tag - if you want this picked up by any of the automated tooling, it won't be. (And you probably do given DG2 is out of force probe.)

ENOCOFFEE - replying to re-surrected ancient thread so I guess this does not matter any more.

Regards,

Tvrtko



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux