On Mon, Dec 05, 2022 at 12:50:53PM +0200, Jani Nikula wrote: > On Thu, 01 Dec 2022, <ye.xingchen@xxxxxxxxxx> wrote: > > From: ye xingchen <ye.xingchen@xxxxxxxxxx> > > > > Replace the open-code with sysfs_emit() to simplify the code. > > I was going to push this, but noticed the function has a third > scnprintf(), and the last two play together with count. It would be > confusing to have a mix of sysfs_emit() and scnprintf(). The third one > can't be blindly converted to sysfs_emit() because it writes at an > offset not aligned by PAGE_SIZE. > > So I'm not taking this. > Hi Jani, Fortunately you'd NAKed this patch from ZTE people, which are known for ignoring your (and others) patch review. Remember that they were used to send from cgel.zte gmail account [1], which after the address was banned from LKML, they tried to send from their own corporate account but Greg suspected that emails sent from them are spoofed [2]. Thanks. [1]: https://lore.kernel.org/lkml/878rn1dd8l.fsf@xxxxxxxxx/ [2]: https://lore.kernel.org/lkml/Y3NqyDDGz%2FUKPgxM@xxxxxxxxx/ -- An old man doll... just what I always wanted! - Clara
Attachment:
signature.asc
Description: PGP signature
