> > struct intel_pxp { > > + /** @i915: back poiner to i915*/ > > + struct drm_i915_private *i915; > > do you really need this pointer back here? > or using a container_of should be enough? I realize i can drop the i915 backptr as i can use pxp->ctrl_gt->i915.