Re: [PATCH] drm/i915/mtl: Add support for 32 bit OAG formats in MTL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 29 Nov 2022 17:17:13 -0800, Dixit, Ashutosh wrote:
>
> > @@ -4746,6 +4772,7 @@ static void oa_init_supported_formats(struct i915_perf *perf)
> >		break;
> >
> >	case INTEL_DG2:
> > +	case INTEL_METEORLAKE:
> >		oa_format_add(perf, I915_OAR_FORMAT_A32u40_A4u32_B8_C8);
> >		oa_format_add(perf, I915_OA_FORMAT_A24u40_A14u32_B8_C8);
>
> Do these formats also need to be added?

Sorry!

>		oa_format_add(perf, I915_OAR_FORMAT_A32u40_A4u32_B8_C8);
>		oa_format_add(perf, I915_OA_FORMAT_A24u40_A14u32_B8_C8);

These two are the same as above.

>		oa_format_add(perf, I915_OAR_FORMAT_A36u64_B8_C8);
>		oa_format_add(perf, I915_OA_FORMAT_A38u64_R2u64_B8_C8);

And it seems these are not 32 bit (where 32 bit refers to the header
size).

> Or these are not considered OAG formats?

So it's ok, no changes needed here.

>
> >		break;

> Thanks.
> --
> Ashutosh



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux