On Tue, 22 Nov 2022, Kees Cook <keescook@xxxxxxxxxxxx> wrote: > On Tue, Nov 22, 2022 at 02:09:48PM +0200, Jani Nikula wrote: >> If phy is PHY_NONE, the shift to register bits becomes negative. Check >> and warn about this. >> >> Reported-by: coverity-bot <keescook@xxxxxxxxxxxx> >> References: https://lore.kernel.org/r/202211180848.D39006C@keescook >> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> Thanks for the review, pushed to drm-intel-next. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center