On Tue, 22 Nov 2022 21:10:01 -0800, Ghimiray, Himal Prasad wrote: > > > -----Original Message----- > > From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx> > > Sent: 21 November 2022 17:17 > > To: Ghimiray, Himal Prasad <himal.prasad.ghimiray@xxxxxxxxx>; intel- > > gfx@xxxxxxxxxxxxxxxxxxxxx > > Subject: Re: [PATCH 1/1] drm/i915: Export LMEM max memory > > bandwidth via sysfs > > > > > > On 21/11/2022 10:01, Himal Prasad Ghimiray wrote: > > > Export lmem maximum memory bandwidth to the userspace via sysfs > > > > > > (v2) > > > Add TODO comment to have client parts specific condition (Anshuman) > > > Remove prelim prefix from the sysfs node name (Aravind) > > > > Link to userspace consumer? > [Ghimiray, Himal Prasad] > > Does above comment means stating name of sysfs node in commit message ? No. It means that there has to be a "real" open source userspace program (like Mesa, Level-0/OneApi or another accepted program or UMD) which is actually reading the sysfs file exposed. Without such a consumer, the sysfs addition will not be accepted upstream. E.g. see cover letter here: https://patchwork.freedesktop.org/series/106460/ "An approved Level-0/oneAPI UMD pull request which consumes the exposed defaults can be seen here: https://github.com/intel/compute-runtime/pull/552 " Thanks. -- Ashutosh
