== Series Details == Series: add guard padding around i915_vma (rev2) URL : https://patchwork.freedesktop.org/series/110720/ State : warning == Summary == Error: dim checkpatch failed c3b7961dfa97 drm/i915: Wrap all access to i915_vma.node.start|size -:263: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #263: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c:475: + GEM_BUG_ON(i915_vma_offset(vma) != addr); -:355: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #355: FILE: drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c:65: + GEM_BUG_ON(offset + (count - 1) * PAGE_SIZE > i915_vma_size(vma)); -:392: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #392: FILE: drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c:223: + GEM_BUG_ON(vma->fence_size > i915_vma_size(vma)); -:786: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #786: FILE: drivers/gpu/drm/i915/i915_vma.c:450: + GEM_BUG_ON(vma->size > i915_vma_size(vma)); -:869: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #869: FILE: drivers/gpu/drm/i915/i915_vma.h:146: + GEM_BUG_ON(!drm_mm_node_allocated(&vma->node)); -:891: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #891: FILE: drivers/gpu/drm/i915/i915_vma.h:168: + GEM_BUG_ON(!drm_mm_node_allocated(&vma->node)); -:902: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #902: FILE: drivers/gpu/drm/i915/i915_vma.h:176: + GEM_BUG_ON(upper_32_bits(i915_vma_offset(vma))); -:903: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #903: FILE: drivers/gpu/drm/i915/i915_vma.h:177: + GEM_BUG_ON(upper_32_bits(i915_vma_offset(vma) + total: 0 errors, 8 warnings, 0 checks, 805 lines checked e9c3d6cce4d8 drm/i915: Introduce guard pages to i915_vma -:128: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #128: FILE: drivers/gpu/drm/i915/i915_vma.c:783: + GEM_BUG_ON(2 * guard > end); -:208: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_node' - possible side-effects? #208: FILE: drivers/gpu/drm/i915/i915_vma_resource.c:37: +#define VMA_RES_START(_node) ((_node)->start - (_node)->guard) -:209: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_node' - possible side-effects? #209: FILE: drivers/gpu/drm/i915/i915_vma_resource.c:38: +#define VMA_RES_LAST(_node) ((_node)->start + (_node)->node_size + (_node)->guard - 1) total: 0 errors, 1 warnings, 2 checks, 196 lines checked 487b3397fb48 drm/i915: Refine VT-d scanout workaround -:125: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #125: FILE: drivers/gpu/drm/i915/i915_vma.c:762: + GEM_BUG_ON(hweight64(flags & (PIN_OFFSET_GUARD | PIN_OFFSET_FIXED | PIN_OFFSET_BIAS)) > 1); -:134: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #134: FILE: drivers/gpu/drm/i915/i915_vma.c:778: + GEM_BUG_ON(overflows_type(flags & PIN_OFFSET_MASK, u32)); total: 0 errors, 2 warnings, 0 checks, 95 lines checked 094fcfb78427 Revert "drm/i915: Improve on suspend / resume time with VT-d enabled"