Hi, Anusha. On Tue, Nov 22, 2022 at 02:27:05PM -0300, Srivatsa, Anusha wrote: > > > > -----Original Message----- > > From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of > > Gustavo Sousa > > Sent: Tuesday, November 22, 2022 4:14 AM > > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > Subject: [PATCH v2] drm/i915/dmc: Update DG2 DMC version to > > v2.08 > > > > Release notes: > > > > 1. Fixes for Register noclaims and few restore. > > > > Signed-off-by: Gustavo Sousa <gustavo.sousa@xxxxxxxxx> > > --- > > > > v2: > > - Use correct numbering for the minor version (8 instead of the > > invalid octal 08). > > > > drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c > > b/drivers/gpu/drm/i915/display/intel_dmc.c > > index 081a4d0083b1..eff3add70611 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dmc.c > > +++ b/drivers/gpu/drm/i915/display/intel_dmc.c > > @@ -52,8 +52,8 @@ > > > > #define DISPLAY_VER12_DMC_MAX_FW_SIZE ICL_DMC_MAX_FW_SIZE > > > > -#define DG2_DMC_PATH DMC_PATH(dg2, 2, 07) > > -#define DG2_DMC_VERSION_REQUIRED DMC_VERSION(2, 07) > > +#define DG2_DMC_PATH DMC_PATH(dg2, 2, 08) > > +#define DG2_DMC_VERSION_REQUIRED DMC_VERSION(2, 8) > ^^^^^this should be (2,08) The v1 was using 08, but the problem is that this value is interpreted as a bad octal, and that caused the compiler to rightfully complain about it :-). While the path should contain the "08", I believe the version required must contain valid numbers and we should represent them in the decimal base. There are other similar examples in this file. -- Gustavo Sousa
