== Series Details == Series: drm/i915: Add support for GSC FW loading URL : https://patchwork.freedesktop.org/series/111170/ State : warning == Summary == Error: dim checkpatch failed 450d4acc03ed drm/i915/uc: Introduce GSC FW Traceback (most recent call last): File "scripts/spdxcheck.py", line 11, in <module> import git ModuleNotFoundError: No module named 'git' Traceback (most recent call last): File "scripts/spdxcheck.py", line 11, in <module> import git ModuleNotFoundError: No module named 'git' -:10: WARNING:TYPO_SPELLING: 'overriden' may be misspelled - perhaps 'overridden'? #10: Similarly to the other FWs, the GSC FW path can be overriden via ^^^^^^^^^ -:53: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 -:79: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #79: FILE: drivers/gpu/drm/i915/gt/uc/intel_gsc_uc.c:22: + GEM_BUG_ON(!gt_is_root(gt) && !gt->info.engine_mask); -:97: ERROR:SPACING: space required before the open brace '{' #97: FILE: drivers/gpu/drm/i915/gt/uc/intel_gsc_uc.c:40: + if (!gsc_engine_supported(gsc_uc_to_gt(gsc))){ -:165: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #165: FILE: drivers/gpu/drm/i915/gt/uc/intel_gsc_uc.h:32: + GEM_BUG_ON(__intel_uc_fw_status(&gsc->fw) == INTEL_UC_FIRMWARE_SELECTED); -:270: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #270: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:22: + GEM_BUG_ON(type >= INTEL_UC_FW_NUM_TYPES); -:333: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #333: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h:67: }; +#define INTEL_UC_FW_NUM_TYPES 3 -:355: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #355: FILE: drivers/gpu/drm/i915/i915_params.c:196: +i915_param_named_unsafe(gsc_firmware_path, charp, 0400, + "GSC firmware path to use instead of the default one"); total: 1 errors, 5 warnings, 2 checks, 289 lines checked 4a0e0515da43 drm/i915/gsc: Skip the version check when fetching the GSC FW 33d39c597ad6 drm/i915/gsc: GSC firmware loading Traceback (most recent call last): File "scripts/spdxcheck.py", line 11, in <module> import git ModuleNotFoundError: No module named 'git' Traceback (most recent call last): File "scripts/spdxcheck.py", line 11, in <module> import git ModuleNotFoundError: No module named 'git' -:103: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #103: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:440: +#define HECI1_FW_LIMIT_VALID (1<<31) ^ -:131: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #131: new file mode 100644 -:495: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #495: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:843: + GEM_BUG_ON(!intel_uc_fw_is_loadable(uc_fw)); total: 0 errors, 2 warnings, 1 checks, 430 lines checked 4ec90ede72df drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded -:104: WARNING:RETURN_VOID: void function return statements are not generally useful #104: FILE: drivers/gpu/drm/i915/intel_uncore.c:2746: + return; +} total: 0 errors, 1 warnings, 0 checks, 106 lines checked 79ac96c18521 drm/i915/gsc: Disable GSC engine and power well if FW is not selected 69e22032d6be drm/i915/mtl: MTL has one GSC CS on the media GT
