On Fri, 18 Nov 2022, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > The DVO encoder init code is meesy. Try to clean it > up a bit, and fix a few buglets while at it. On the series, Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > Ville Syrjälä (9): > drm/i915/dvo: Remove unused panel_wants_dither > drm/i915/dvo: Don't leak connector state on DVO init failure > drm/i915/dvo: Actually initialize the DVO encoder type > drm/i915/dvo: Introduce intel_dvo_connector_type() > drm/i915/dvo: Eliminate useless 'port' variable > drm/i915/dvo: Flatten intel_dvo_init() > drm/i915/dvo: s/intel_encoder/encoder/ etc. > drm/i915/dvo: s/dev_priv/i915/ > drm/i915/dvo: Use per device debugs > > drivers/gpu/drm/i915/display/intel_dvo.c | 375 ++++++++++++----------- > 1 file changed, 201 insertions(+), 174 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center