MTL has two tiles that is represented by the intel_gt structure in the i915
code. The PXP feature has a control-structure that contains the PXP context
and this hangs of the intel_gt structure. In MTL, the standalone media tile
(i.e. not the root tile) contains the VDBOX and KCR engine which is what
PXP relies on for establishing and tearing down the PXP session. However
PXP is a global feature as other engines on other tiles can reference the
PXP session in object info within batch buffer instructions.That coherrency
is handled implicitly by the HW. However current intel_pxp functions such
as intel_pxp_enabled, intel_pxp_start and others take in the intel_gt
structure pointer as its input thus creation the perception that PXP is
a GT-tile specific domain that is independant from other GT tiles.
This series updates all of the intel_pxp_foo functions that are accessed
from outside the PXP subsystem so that the callers only need to pass in the
i915 structure as the input param (being a global handle). Internally,
these functions will loop through all available GT structures on the GPU
and find the one GT structure that contains the one PXP+TEE control
structure before proceeding with the rest of its operation.
Changes from prior revs:
v3: - Rename gt level helper functions to "intel_pxp_is_enabled/supported/
active_on_gt" (Daniele)
- Upgrade _gt_supports_pxp to replace what was intel_gtpxp_is_supported
as the new intel_pxp_is_supported_on_gt to check for PXP feature
support vs the tee support for huc authentication. Fix pxp-debugfs-
registration to use only the former to decide support. (Daniele)
- Couple minor optimizations.
v2: - Avoid introduction of new device info or gt variables and use
existing checks / macros to differentiate the correct GT->PXP
control ownership (Daniele Ceraolo Spurio)
- Don't reuse the updated global-checkers for per-GT callers (such
as other files within PXP) to avoid unnecessary GT-reparsing,
expose a replacement helper like the prior ones. (Daniele).
v1: Add one more patch to the series for the intel_pxp suspend/resume
for similiar refactoring
Patches that received R-B so far:
Patch 4, 5, 6.
Alan Previn (6):
drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT
drm/i915/pxp: Make intel_pxp_is_enabled implicitly sort PXP-owning-GT
drm/i915/pxp: Make intel_pxp_is_active implicitly sort PXP-owning-GT
drm/i915/pxp: Make PXP tee component bind/unbind aware of
PXP-owning-GT
drm/i915/pxp: Make intel_pxp_start implicitly sort PXP-owning-GT
drm/i915/pxp: Make intel_pxp_key_check implicitly sort PXP-owning-GT
.../drm/i915/display/skl_universal_plane.c | 2 +-
drivers/gpu/drm/i915/gem/i915_gem_context.c | 6 +-
drivers/gpu/drm/i915/gem/i915_gem_create.c | 2 +-
.../gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +-
drivers/gpu/drm/i915/i915_drv.h | 4 -
drivers/gpu/drm/i915/pxp/intel_pxp.c | 83 ++++++++++++++++---
drivers/gpu/drm/i915/pxp/intel_pxp.h | 16 +++-
drivers/gpu/drm/i915/pxp/intel_pxp_cmd.c | 2 +-
drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 8 +-
drivers/gpu/drm/i915/pxp/intel_pxp_irq.c | 4 +-
drivers/gpu/drm/i915/pxp/intel_pxp_pm.c | 8 +-
drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 18 +++-
12 files changed, 114 insertions(+), 41 deletions(-)
base-commit: b7288a4715c68710aadbd63112b699356e8a2b65
--
2.34.1
