On Fri, Jul 26, 2013 at 10:12:43AM -0700, Jesse Barnes wrote: > On Fri, 26 Jul 2013 18:08:48 +0100 > Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > > On Fri, Jul 26, 2013 at 09:59:42AM -0700, Jesse Barnes wrote: > > > 4) review comments should be concrete and actionable, and ideally not > > > leave the author hanging with hints about problems the reviewer > > > has spotted, leaving the author looking for easter eggs > > > > Where am I going to find my fun, if I am not allowed to tell you that > > you missed a zero in a thousand line patch but not tell you where? > > Spoilsport :-p > > You'll just need to take up golf or something. :) Poignant opinion from the guy who bored himself on vacations: I disagree on two grounds: Chris without the occasional easter-egg sprinkling just wouldn't be Chris anymore, at least how I know him. Imo we're a bunch of individuals, quirks and all, not a pile of interchangeable cogs that just churn out code. And yes am as amused as the next guy when I spoil by pants by inadvertedly sitting in one of Chris' easter-eggs, otoh I can't help not grinning when I discover them in time ;-) Which leads to the "where's the fun?" question. I've started hacking on drm/i915 because it's fun (despite the frustration). And the fun is what keeps me slogging through bug reports each morning. So if we ditch that in the name of efficiency that'll affect my productivity a lot (just not in the intended direction) and you'll probably need to look for a new maintainer ... With that out of the way I'm obviously not advocating for unclear review - mail is an occasional rather lossy communication medium and we need to keep that in mind all the time. I'm only against your easter egg comment, since throwing those out with the badwather is imo bad. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
