On Fri, 26 Jul 2013 18:08:48 +0100 Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > On Fri, Jul 26, 2013 at 09:59:42AM -0700, Jesse Barnes wrote: > > 4) review comments should be concrete and actionable, and ideally not > > leave the author hanging with hints about problems the reviewer > > has spotted, leaving the author looking for easter eggs > > Where am I going to find my fun, if I am not allowed to tell you that > you missed a zero in a thousand line patch but not tell you where? > Spoilsport :-p You'll just need to take up golf or something. :) -- Jesse Barnes, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
