== Series Details == Series: drm/i915: Finish (de)gamma readout (rev6) URL : https://patchwork.freedesktop.org/series/79614/ State : warning == Summary == Error: dim checkpatch failed 050b3fdee02b drm/i915: Clean up legacy palette defines 48cfd1bd8b47 drm/i915: Clean up 10bit precision palette defines -:31: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #31: FILE: drivers/gpu/drm/i915/display/intel_color.c:475: + REG_FIELD_PREP(PREC_PALETTE_10_GREEN_MASK, drm_color_lut_extract(color->green, 10)) | total: 0 errors, 1 warnings, 0 checks, 48 lines checked 865e3889fa66 drm/i915: Clean up 12.4bit precision palette defines 6237eba7dad6 drm/i915: Clean up chv CGM (de)gamma defines -:29: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #29: FILE: drivers/gpu/drm/i915/display/intel_color.c:1081: + return REG_FIELD_PREP(CGM_PIPE_DEGAMMA_GREEN_LDW_MASK, drm_color_lut_extract(color->green, 14)) | -:30: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #30: FILE: drivers/gpu/drm/i915/display/intel_color.c:1082: + REG_FIELD_PREP(CGM_PIPE_DEGAMMA_BLUE_LDW_MASK, drm_color_lut_extract(color->blue, 14)); -:46: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #46: FILE: drivers/gpu/drm/i915/display/intel_color.c:1108: + return REG_FIELD_PREP(CGM_PIPE_GAMMA_GREEN_LDW_MASK, drm_color_lut_extract(color->green, 10)) | -:47: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #47: FILE: drivers/gpu/drm/i915/display/intel_color.c:1109: + REG_FIELD_PREP(CGM_PIPE_GAMMA_BLUE_LDW_MASK, drm_color_lut_extract(color->blue, 10)); total: 0 errors, 4 warnings, 0 checks, 65 lines checked de1edc42f0bc drm/i915: Reorder 12.4 lut udw vs. ldw functions 253540f25651 drm/i915: Fix adl+ degamma LUT size 4729e0a3d521 drm/i915: Add glk+ degamma readout 409d2cf59467 drm/i915: Read out CHV CGM degamma -:27: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #27: FILE: drivers/gpu/drm/i915/display/intel_color.c:1092: + entry->green = intel_color_lut_pack(REG_FIELD_GET(CGM_PIPE_DEGAMMA_GREEN_LDW_MASK, ldw), 14); total: 0 errors, 1 warnings, 0 checks, 54 lines checked d1e5a4707798 drm/i915: Add gamma/degamma readout for bdw+ 6b3640d4cb55 drm/i915: Add gamma/degamma readout for ivb/hsw 89efbdff053a drm/i915: Make ilk_read_luts() capable of degamma readout 92e6c0fe9d7f drm/i915: Make .read_luts() mandatory 1e0d6364e43b drm/i915: Finish the LUT state checker -:515: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'lut' - possible side-effects? #515: FILE: drivers/gpu/drm/i915/display/intel_display.c:5679: +#define PIPE_CONF_CHECK_COLOR_LUT(lut, is_pre_csc_lut) do { \ + if (current_config->gamma_mode == pipe_config->gamma_mode && \ + !intel_color_lut_equal(current_config, \ + current_config->lut, pipe_config->lut, \ + is_pre_csc_lut)) { \ + pipe_config_mismatch(fastset, crtc, __stringify(lut), \ + "hw_state doesn't match sw_state"); \ + ret = false; \ } \ } while (0) -:515: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'lut' may be better as '(lut)' to avoid precedence issues #515: FILE: drivers/gpu/drm/i915/display/intel_display.c:5679: +#define PIPE_CONF_CHECK_COLOR_LUT(lut, is_pre_csc_lut) do { \ + if (current_config->gamma_mode == pipe_config->gamma_mode && \ + !intel_color_lut_equal(current_config, \ + current_config->lut, pipe_config->lut, \ + is_pre_csc_lut)) { \ + pipe_config_mismatch(fastset, crtc, __stringify(lut), \ + "hw_state doesn't match sw_state"); \ + ret = false; \ } \ } while (0) total: 0 errors, 0 warnings, 2 checks, 480 lines checked eb8dc7921dc0 drm/i915: Rework legacy LUT handling 273b8810dc4d drm/i915: Use hw degamma LUT for sw gamma on glk with YCbCr output -:93: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "crtc_state->post_csc_lut" #93: FILE: drivers/gpu/drm/i915/display/intel_color.c:1419: + crtc_state->post_csc_lut != NULL && total: 0 errors, 0 warnings, 1 checks, 131 lines checked 50bd7750c49b drm/i915: Use gamma LUT for RGB limited range compression 8d4a58857dd9 drm/i915: Add 10bit gamma mode for gen2/3 89d268b2c032 drm/i915: Do state check for color management changes