== Series Details == Series: drm/i915: ELD precompute and readout (rev4) URL : https://patchwork.freedesktop.org/series/109592/ State : warning == Summary == Error: dim checkpatch failed dd5b3afe38e7 drm/i915/audio: Don't program the hardware ELD buffer on ilk+ 663c2d197a11 drm/i915/audio: Don't program the hardware ELD buffer on hsw+ -:33: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #33: References: https://lore.kernel.org/intel-gfx/20221012104936.30911-1-ville.syrjala@xxxxxxxxxxxxxxx/ total: 0 errors, 1 warnings, 0 checks, 56 lines checked 45ba9d086b99 drm/i915/audio: Unify get_saved_enc() 223b8cd348ec drm/i915/audio: Realign some function arguments 1e495a4f847c drm/i915/audio: Introduce a struct for the acomp audio state -:248: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "audio_state->connector" #248: FILE: drivers/gpu/drm/i915/display/intel_audio.c:1175: + *enabled = audio_state->connector != NULL; total: 0 errors, 0 warnings, 1 checks, 253 lines checked 8c22657785b9 drm/i915/audio: Precompute the ELD -:133: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "audio_state->encoder" #133: FILE: drivers/gpu/drm/i915/display/intel_audio.c:1187: + *enabled = audio_state->encoder != NULL; total: 0 errors, 0 warnings, 1 checks, 164 lines checked 69036cdc509c drm/i915/audio: Don't enable audio with bogus ELD 0567a74a66b3 drm/i915/audio: Hardware ELD readout b616451d3973 drm/i915/sdvo: Precompute the ELD cb1307fa641a drm/i915/sdvo: Only use "presence detect" for has_audio readout a48ee0c45ec7 drm/i915/sdvo: Do ELD hardware readout 8856bf4484bb drm/i915/audio: Hook up ELD into the state checker -:72: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects? #72: FILE: drivers/gpu/drm/i915/display/intel_display.c:5710: +#define PIPE_CONF_CHECK_BUFFER(name, len) do { \ + BUILD_BUG_ON(sizeof(current_config->name) != (len)); \ + BUILD_BUG_ON(sizeof(pipe_config->name) != (len)); \ + if (!intel_compare_buffer(current_config->name, pipe_config->name, (len))) { \ + pipe_config_buffer_mismatch(dev_priv, fastset, __stringify(name), \ + current_config->name, \ + pipe_config->name, \ + (len)); \ + ret = false; \ + } \ +} while (0) -:72: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues #72: FILE: drivers/gpu/drm/i915/display/intel_display.c:5710: +#define PIPE_CONF_CHECK_BUFFER(name, len) do { \ + BUILD_BUG_ON(sizeof(current_config->name) != (len)); \ + BUILD_BUG_ON(sizeof(pipe_config->name) != (len)); \ + if (!intel_compare_buffer(current_config->name, pipe_config->name, (len))) { \ + pipe_config_buffer_mismatch(dev_priv, fastset, __stringify(name), \ + current_config->name, \ + pipe_config->name, \ + (len)); \ + ret = false; \ + } \ +} while (0) -:72: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'len' - possible side-effects? #72: FILE: drivers/gpu/drm/i915/display/intel_display.c:5710: +#define PIPE_CONF_CHECK_BUFFER(name, len) do { \ + BUILD_BUG_ON(sizeof(current_config->name) != (len)); \ + BUILD_BUG_ON(sizeof(pipe_config->name) != (len)); \ + if (!intel_compare_buffer(current_config->name, pipe_config->name, (len))) { \ + pipe_config_buffer_mismatch(dev_priv, fastset, __stringify(name), \ + current_config->name, \ + pipe_config->name, \ + (len)); \ + ret = false; \ + } \ +} while (0) total: 0 errors, 0 warnings, 3 checks, 67 lines checked 7d6e5434606e drm/i915/audio: Include ELD in the state dump c0ec1cafa02d drm/i915/audio: s/ilk/ibx/ bf235da3024e drm/i915/audio: Clean up the PCH type checks
