== Series Details == Series: drm/i915: header cleanups, cont'd URL : https://patchwork.freedesktop.org/series/110716/ State : warning == Summary == Error: dim checkpatch failed a1c8e7edfaca drm/i915/reg: move masked field helpers to i915_reg_defs.h -:48: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects? #48: FILE: drivers/gpu/drm/i915/i915_reg_defs.h:102: +#define _MASKED_FIELD(mask, value) ({ \ + if (__builtin_constant_p(mask)) \ + BUILD_BUG_ON_MSG(((mask) & 0xffff0000), "Incorrect mask"); \ + if (__builtin_constant_p(value)) \ + BUILD_BUG_ON_MSG((value) & 0xffff0000, "Incorrect value"); \ + if (__builtin_constant_p(mask) && __builtin_constant_p(value)) \ + BUILD_BUG_ON_MSG((value) & ~(mask), \ + "Incorrect value for mask"); \ + __MASKED_FIELD(mask, value); }) -:48: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'value' - possible side-effects? #48: FILE: drivers/gpu/drm/i915/i915_reg_defs.h:102: +#define _MASKED_FIELD(mask, value) ({ \ + if (__builtin_constant_p(mask)) \ + BUILD_BUG_ON_MSG(((mask) & 0xffff0000), "Incorrect mask"); \ + if (__builtin_constant_p(value)) \ + BUILD_BUG_ON_MSG((value) & 0xffff0000, "Incorrect value"); \ + if (__builtin_constant_p(mask) && __builtin_constant_p(value)) \ + BUILD_BUG_ON_MSG((value) & ~(mask), \ + "Incorrect value for mask"); \ + __MASKED_FIELD(mask, value); }) total: 0 errors, 0 warnings, 2 checks, 38 lines checked a3b636f83d37 drm/i915/reg: move pick even and pick to reg defs -:55: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__a' - possible side-effects? #55: FILE: drivers/gpu/drm/i915/i915_reg_defs.h:120: +#define _PICK_EVEN(__index, __a, __b) ((__a) + (__index) * ((__b) - (__a))) total: 0 errors, 0 warnings, 1 checks, 42 lines checked 3a98d29dd753 drm/i915: split out intel_display_reg_defs.h Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in <module> from ply import lex, yacc ModuleNotFoundError: No module named 'ply' -:57: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #57: new file mode 100644 -:107: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #107: FILE: drivers/gpu/drm/i915/display/intel_display_reg_defs.h:46: +#define _MMIO_TRANS2(tran, reg) _MMIO(INTEL_INFO(dev_priv)->display.trans_offsets[(tran)] - \ -:108: WARNING:LONG_LINE: line length of 107 exceeds 100 columns #108: FILE: drivers/gpu/drm/i915/display/intel_display_reg_defs.h:47: + INTEL_INFO(dev_priv)->display.trans_offsets[TRANSCODER_A] + \ -:110: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #110: FILE: drivers/gpu/drm/i915/display/intel_display_reg_defs.h:49: +#define _MMIO_CURSOR2(pipe, reg) _MMIO(INTEL_INFO(dev_priv)->display.cursor_offsets[(pipe)] - \ -:111: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #111: FILE: drivers/gpu/drm/i915/display/intel_display_reg_defs.h:50: + INTEL_INFO(dev_priv)->display.cursor_offsets[PIPE_A] + \ total: 0 errors, 5 warnings, 0 checks, 176 lines checked b2c1abcfaf49 drm/i915: stop including i915_irq.h from i915_trace.h