On Wed, 09 Nov 2022, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> Introduce a plaec where we can initialize connector->panel
*place
> after it's been allocated. We already have a intel_panel_init()
> so had to get creative with the name and came up with
> intel_panel_init_alloc().
A bit contrived, but no big deal.
Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> Cc: Animesh Manna <animesh.manna@xxxxxxxxx>
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/display/intel_connector.c | 2 +-
> drivers/gpu/drm/i915/display/intel_panel.c | 7 +++++++
> drivers/gpu/drm/i915/display/intel_panel.h | 1 +
> 3 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_connector.c b/drivers/gpu/drm/i915/display/intel_connector.c
> index 6205ddd3ded0..562da3b741e2 100644
> --- a/drivers/gpu/drm/i915/display/intel_connector.c
> +++ b/drivers/gpu/drm/i915/display/intel_connector.c
> @@ -54,7 +54,7 @@ int intel_connector_init(struct intel_connector *connector)
> __drm_atomic_helper_connector_reset(&connector->base,
> &conn_state->base);
>
> - INIT_LIST_HEAD(&connector->panel.fixed_modes);
> + intel_panel_init_alloc(connector);
>
> return 0;
> }
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
> index 69ce77711b7c..8e683ab75594 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.c
> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> @@ -660,6 +660,13 @@ intel_panel_mode_valid(struct intel_connector *connector,
> return MODE_OK;
> }
>
> +void intel_panel_init_alloc(struct intel_connector *connector)
> +{
> + struct intel_panel *panel = &connector->panel;
> +
> + INIT_LIST_HEAD(&panel->fixed_modes);
> +}
> +
> int intel_panel_init(struct intel_connector *connector)
> {
> struct intel_panel *panel = &connector->panel;
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.h b/drivers/gpu/drm/i915/display/intel_panel.h
> index 5c5b5b7f95b6..4b51e1c51da6 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.h
> +++ b/drivers/gpu/drm/i915/display/intel_panel.h
> @@ -18,6 +18,7 @@ struct intel_connector;
> struct intel_crtc_state;
> struct intel_encoder;
>
> +void intel_panel_init_alloc(struct intel_connector *connector);
> int intel_panel_init(struct intel_connector *connector);
> void intel_panel_fini(struct intel_connector *connector);
> enum drm_connector_status
--
Jani Nikula, Intel Open Source Graphics Center
