Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_create: use cpu_size in always_clear

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 11/2/2022 11:52 AM, Matthew Auld wrote:
If the we can't fit the buffer in the CPU visible portion of lmem, then

Need a minor fix of above sentence(unwanted "the")

Reviewed-by: Nirmoy Das <nirmoy.das@xxxxxxxxx>

the kernel will be unable to migrate the pages on fault on small-bar
systems.  Note that this doesn't restrict where the pages are allocated,
but should just ensure we don't SIGBUS, if we need to migrate the pages.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6967
Signed-off-by: Matthew Auld <matthew.auld@xxxxxxxxx>
Cc: Nirmoy Das <nirmoy.das@xxxxxxxxx>
---
  tests/i915/gem_create.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
index 9c695fa4..af530ccc 100644
--- a/tests/i915/gem_create.c
+++ b/tests/i915/gem_create.c
@@ -271,7 +271,7 @@ static void always_clear(int i915, const struct gem_memory_region *r, int timeou
  	struct thread_clear arg = {
  		.i915 = i915,
  		.region = r->ci,
-		.max = r->size / 2 >> 12, /* in pages */
+		.max = r->cpu_size / 2 >> 12, /* in pages */
  		.timeout = timeout,
  	};
  	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux