== Series Details == Series: drm/i915/hwmon: Don't use FIELD_PREP (rev2) URL : https://patchwork.freedesktop.org/series/110301/ State : warning == Summary == Error: dim checkpatch failed 6a7780f724ae drm/i915/hwmon: Don't use FIELD_PREP -:46: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__mask' - possible side-effects? #46: FILE: drivers/gpu/drm/i915/i915_reg_defs.h:70: +#define __REG_FIELD_PREP_CHK(__mask, __val) \ + (BUILD_BUG_ON_ZERO(!__is_constexpr(__mask)) + \ + BUILD_BUG_ON_ZERO((__mask) == 0 || (__mask) > U32_MAX) + \ + BUILD_BUG_ON_ZERO(!IS_POWER_OF_2((__mask) + (1ULL << __bf_shf(__mask)))) + \ + BUILD_BUG_ON_ZERO(__builtin_choose_expr(__is_constexpr(__val), (~((__mask) >> __bf_shf(__mask)) & (__val)), 0))) -:46: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__val' - possible side-effects? #46: FILE: drivers/gpu/drm/i915/i915_reg_defs.h:70: +#define __REG_FIELD_PREP_CHK(__mask, __val) \ + (BUILD_BUG_ON_ZERO(!__is_constexpr(__mask)) + \ + BUILD_BUG_ON_ZERO((__mask) == 0 || (__mask) > U32_MAX) + \ + BUILD_BUG_ON_ZERO(!IS_POWER_OF_2((__mask) + (1ULL << __bf_shf(__mask)))) + \ + BUILD_BUG_ON_ZERO(__builtin_choose_expr(__is_constexpr(__val), (~((__mask) >> __bf_shf(__mask)) & (__val)), 0))) -:50: WARNING:LONG_LINE: line length of 121 exceeds 100 columns #50: FILE: drivers/gpu/drm/i915/i915_reg_defs.h:74: + BUILD_BUG_ON_ZERO(__builtin_choose_expr(__is_constexpr(__val), (~((__mask) >> __bf_shf(__mask)) & (__val)), 0))) -:52: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__mask' - possible side-effects? #52: FILE: drivers/gpu/drm/i915/i915_reg_defs.h:76: +#define __REG_FIELD_PREP(__mask, __val) \ + ((u32)((((typeof(__mask))(__val) << __bf_shf(__mask)) & (__mask)))) -:55: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__mask' - possible side-effects? #55: FILE: drivers/gpu/drm/i915/i915_reg_defs.h:79: +#define REG_FIELD_PREP(__mask, __val) \ + (__REG_FIELD_PREP(__mask, __val) + __REG_FIELD_PREP_CHK(__mask, __val)) -:55: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__val' - possible side-effects? #55: FILE: drivers/gpu/drm/i915/i915_reg_defs.h:79: +#define REG_FIELD_PREP(__mask, __val) \ + (__REG_FIELD_PREP(__mask, __val) + __REG_FIELD_PREP_CHK(__mask, __val)) total: 0 errors, 1 warnings, 5 checks, 31 lines checked
