On Fri, 28 Oct 2022 at 16:51, Matthew Auld <matthew.auld@xxxxxxxxx> wrote:
>
> From: "Michael J. Ruhl" <michael.j.ruhl@xxxxxxxxx>
>
> Update open coded for loop to use the standard scatterlist
> for_each_sg API.
>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@xxxxxxxxx>
Reviewed-by: Matthew Auld <matthew.auld@xxxxxxxxx>
> Signed-off-by: Matthew Auld <matthew.auld@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> index 8342e01a0d27..ec6f7ae47783 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> @@ -47,12 +47,10 @@ static struct sg_table *i915_gem_map_dma_buf(struct dma_buf_attachment *attach,
> if (ret)
> goto err_free;
>
> - src = obj->mm.pages->sgl;
> dst = sgt->sgl;
> - for (i = 0; i < obj->mm.pages->orig_nents; i++) {
> + for_each_sg(obj->mm.pages->sgl, src, obj->mm.pages->orig_nents, i) {
> sg_set_page(dst, sg_page(src), src->length, 0);
> dst = sg_next(dst);
> - src = sg_next(src);
> }
>
> ret = dma_map_sgtable(attach->dev, sgt, dir, DMA_ATTR_SKIP_CPU_SYNC);
> --
> 2.37.3
>
