== Series Details == Series: drm/i915: Audio stuff (rev2) URL : https://patchwork.freedesktop.org/series/110188/ State : warning == Summary == Error: dim checkpatch failed d5e981d3cb31 drm/i915/audio: s/dev_priv/i915/ -:1033: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "i915->display.audio.lpe.platdev" #1033: FILE: drivers/gpu/drm/i915/display/intel_audio.c:1405: + if (i915->display.audio.lpe.platdev != NULL) total: 0 errors, 0 warnings, 1 checks, 980 lines checked c41db3f96f70 drm/i915/audio: Nuke leftover ROUNDING_FACTOR 93827d906e6a drm/i915/audio: Remove CL/BLC audio stuff aaa8398a5432 drm/i915/audio: Extract struct ilk_audio_regs d31d04e641ca drm/i915/audio: Use REG_BIT() & co. -:159: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #159: FILE: drivers/gpu/drm/i915/display/intel_audio_regs.h:64: +#define AUD_CONFIG_N(n) (REG_FIELD_PREP(AUD_CONFIG_UPPER_N_MASK, (n) >> 12) | \ -:159: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects? #159: FILE: drivers/gpu/drm/i915/display/intel_audio_regs.h:64: +#define AUD_CONFIG_N(n) (REG_FIELD_PREP(AUD_CONFIG_UPPER_N_MASK, (n) >> 12) | \ + REG_FIELD_PREP(AUD_CONFIG_LOWER_N_MASK, (n) & 0xfff)) -:160: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #160: FILE: drivers/gpu/drm/i915/display/intel_audio_regs.h:65: + REG_FIELD_PREP(AUD_CONFIG_LOWER_N_MASK, (n) & 0xfff)) total: 0 errors, 2 warnings, 1 checks, 171 lines checked 4b5a7ea8120e drm/i915/audio: Unify register bit naming cb9af05dabb5 drm/i915/audio: Protect singleton register with a lock 3baeed6a6bf0 drm/i915/audio: Nuke intel_eld_uptodate() dee866fe1f99 drm/i915/audio: Read ELD buffer size from hardware b8dc3881149e drm/i915/audio: Make sure we write the whole ELD buffer 957ecb1cee1f drm/i915/audio: Use u32* for ELD e5c74315831c drm/i915/audio: Use intel_de_rmw() for most audio registers 672dae67c4e6 drm/i915/audio: Split "ELD valid" vs. audio PD on hsw+ 62ae6a195cbd drm/i915/audio: Do the vblank waits 23299d1dbf96 drm/i915/sdvo: Extract intel_sdvo_has_audio()
