Re: [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC

["Belgaumkar, Vinay" <vinay.belgaumkar@xxxxxxxxx>]

On 10/22/2022 12:22 PM, Dixit, Ashutosh wrote:
> On Sat, 22 Oct 2022 10:56:03 -0700, Belgaumkar, Vinay wrote:
> Hi Vinay,
>
> > > > diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
> > > > index fc23c562d9b2..32e1f5dde5bb 100644
> > > > --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> > > > +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> > > > @@ -1016,9 +1016,15 @@ void intel_rps_boost(struct i915_request *rq)
> > > > 		if (rps_uses_slpc(rps)) {
> > > > 			slpc = rps_to_slpc(rps);
> > > >
> > > > +			if (slpc->min_freq_softlimit == slpc->boost_freq)
> > > > +				return;
> > > nit but is it possible that 'slpc->min_freq_softlimit > slpc->boost_freq'
> > > (looks possible to me from the code though we might not have intended it)?
> > > Then we can change this to:
> > >
> > > 			if (slpc->min_freq_softlimit >= slpc->boost_freq)
> > > 				return;
> Any comment about this? It looks clearly possible to me from the code.
>
> So with the above change this is:
>
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx>

Agree.

Thanks,

Vinay.