On Thu, Oct 20, 2022 at 04:45:55PM +0300, Jani Nikula wrote: > On Thu, 20 Oct 2022, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > Some cleanups for checking whether the crtc was flagged for > > modesets/fastsets/color update. > > I wish we could avoid piling more static inlines in > intel_display_types.h, but the clarity added here is great. I mainly put them there since the first one was already there. Dunno if the function call overhead would really be measurable, even though we do use these a lot. Should measure it on some real slouch of a machine I guess. > > On the series, > > Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> Thanks. > > > > > Ville Syrjälä (4): > > drm/i915: Introduce intel_crtc_needs_fastset() > > drm/i915: Remove some local 'mode_changed' bools > > drm/i915: Don't flag both full modeset and fastset at the same time > > drm/i915: Introduce intel_crtc_needs_color_update() > > > > drivers/gpu/drm/i915/display/hsw_ips.c | 8 ++-- > > drivers/gpu/drm/i915/display/intel_crtc.c | 3 +- > > drivers/gpu/drm/i915/display/intel_cursor.c | 6 ++- > > drivers/gpu/drm/i915/display/intel_display.c | 46 +++++++++---------- > > .../drm/i915/display/intel_display_types.h | 14 ++++++ > > .../drm/i915/display/intel_modeset_verify.c | 3 +- > > 6 files changed, 46 insertions(+), 34 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Ville Syrjälä Intel
