Re: signal: break out of wait loops on kthread_stop()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: signal: break out of wait loops on kthread_stop()
- From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>
- Date: Wed, 19 Oct 2022 14:31:01 +0100
- Cc: "Intel-gfx@xxxxxxxxxxxxxxxxxxxxx" <Intel-gfx@xxxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
- Organization: Intel Corporation UK Plc
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2
Hi,
A question regarding a7c01fa93aeb ("signal: break out of wait loops on
kthread_stop()") if I may.
We have a bunch code in i915, possibly limited to self tests (ie debug
builds) but still important for our flows, which spawn kernel threads
and exercises parts of the driver.
Problem we are hitting with this patch is that code did not really need
to be signal aware until now. Well to say that more accurately - we were
able to test the code which is normally executed from userspace, so is
signal aware, but not worry about -ERESTARTSYS or -EINTR within the test
cases itself.
For example threads which exercise an internal API for a while until the
parent calls kthread_stop. Now those tests can hit unexpected errors.
Question is how to best approach working around this change. It is of
course technically possible to rework our code in more than one way,
although with some cost and impact already felt due reduced pass rates
in our automated test suites.
Maybe an opt out kthread flag from this new behavior? Would that be
acceptable as a quick fix? Or any other comments?
Regards,
Tvrtko
[Index of Archives]
[AMD Graphics]
[Linux USB Devel]
[Linux Audio Users]
[Yosemite News]
[Linux Kernel]
[Linux SCSI]