On Fri, 14 Oct 2022, "Kahola, Mika" <mika.kahola@xxxxxxxxx> wrote: > Maybe these could be moved into intel_cx0_reg_defs.h file? Register definitions to intel_cx0_regs.h. See $ find drivers/gpu/drm/i915/ -name "*_regs.h" Any common helpers such as REG_FIELD_GET8() and friends to i915_reg_defs.h where we already have some other sized helpers. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center