On Wed, Oct 12, 2022 at 05:33:31PM +0300, Jani Nikula wrote:
> On Tue, 11 Oct 2022, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> >
> > The audio code does a lot of RMW accesses. Utilize
> > intel_de_rmw() to make that a bit less tedious.
> >
> > There are still some hand rolled RMW left, but those have
> > a lot of code in between the read and write to calculate
> > the new value, so would need some refactoring first.
> >
> > Cc: Chaitanya Kumar Borah <chaitanya.kumar.borah@xxxxxxxxx>
> > Cc: Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>
> > Cc: Takashi Iwai <tiwai@xxxxxxx>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> With commit 06b975d58fd6 ("drm/i915: make intel_uncore_rmw() write
> unconditionally") I feel much more comfortable doing these changes.
Agreed. The write might have a side effect which is important
even when value doesn't change.
--
Ville Syrjälä
Intel
