== Series Details == Series: drm/i915: ELD precompute and readout URL : https://patchwork.freedesktop.org/series/109592/ State : warning == Summary == Error: dim checkpatch failed 47e22e77915e drm/i915/audio: s/dev_priv/i915/ -:592: WARNING:BRACES: braces {} are not necessary for any arm of this statement #592: FILE: drivers/gpu/drm/i915/display/intel_audio.c:937: + if (IS_G4X(i915)) { [...] + } else if (IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915)) { [...] + } else if (IS_HASWELL(i915) || DISPLAY_VER(i915) >= 8) { [...] + } else if (HAS_PCH_SPLIT(i915)) { [...] -:1028: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "i915->display.audio.lpe.platdev" #1028: FILE: drivers/gpu/drm/i915/display/intel_audio.c:1406: + if (i915->display.audio.lpe.platdev != NULL) total: 0 errors, 1 warnings, 1 checks, 979 lines checked 2803483a9b29 drm/i915/audio: Nuke leftover ROUNDING_FACTOR 62eac09b430f drm/i915/audio: Remove CL/BLC audio stuff de2579d777df drm/i915/audio: Exract struct ilk_audio_regs 2b2e9cd3f380 drm/i915/audio: Use REG_BIT() & co. -:159: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #159: FILE: drivers/gpu/drm/i915/display/intel_audio_regs.h:64: +#define AUD_CONFIG_N(n) (REG_FIELD_PREP(AUD_CONFIG_UPPER_N_MASK, (n) >> 12) | \ -:159: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects? #159: FILE: drivers/gpu/drm/i915/display/intel_audio_regs.h:64: +#define AUD_CONFIG_N(n) (REG_FIELD_PREP(AUD_CONFIG_UPPER_N_MASK, (n) >> 12) | \ + REG_FIELD_PREP(AUD_CONFIG_LOWER_N_MASK, (n) & 0xfff)) -:160: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #160: FILE: drivers/gpu/drm/i915/display/intel_audio_regs.h:65: + REG_FIELD_PREP(AUD_CONFIG_LOWER_N_MASK, (n) & 0xfff)) total: 0 errors, 2 warnings, 1 checks, 171 lines checked 3865beff4a92 drm/i915/audio: Unify register bit naming ac09bffae4af drm/i915/audio: Protect singleton register with a lock dfb8803d49b2 drm/i915/audio: Nuke intel_eld_uptodate() b7d138e7bf32 drm/i915/audio: Read ELD buffer size from hardware 9314eb069aa8 drm/i915/audio: Make sure we write the whole ELD buffer e1c44ed2f52d drm/i915/audio: Use u32* for ELD e1c536149130 drm/i915/audio: Use intel_de_rmw() for most audio registers 3fa7be2ea20c drm/i915/audio: Split "ELD valid" vs. audio PD on hsw+ c0774d4dce43 drm/i915/audio: Do the vblank waits 76386e8b32ff drm/i915/audio: Precompute the ELD da521f283990 drm/i915/audio: Hardware ELD readout 4d1780a2872d drm/i915/sdvo: Extract intel_sdvo_has_audio() 64cb45a66433 drm/i915/sdvo: Precompute the ELD bda3798a7f2d drm/i915/sdvo: Do ELD hardware readout 89604a7afe1a drm/i915/audio: Hook up ELD into the state checker -:71: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects? #71: FILE: drivers/gpu/drm/i915/display/intel_display.c:5734: +#define PIPE_CONF_CHECK_BUFFER(name, len) do { \ + BUILD_BUG_ON(sizeof(current_config->name) != (len)); \ + BUILD_BUG_ON(sizeof(pipe_config->name) != (len)); \ + if (!intel_compare_buffer(current_config->name, pipe_config->name, (len))) { \ + pipe_config_buffer_mismatch(dev_priv, fastset, __stringify(name), \ + current_config->name, \ + pipe_config->name, \ + (len)); \ + ret = false; \ + } \ +} while (0) -:71: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues #71: FILE: drivers/gpu/drm/i915/display/intel_display.c:5734: +#define PIPE_CONF_CHECK_BUFFER(name, len) do { \ + BUILD_BUG_ON(sizeof(current_config->name) != (len)); \ + BUILD_BUG_ON(sizeof(pipe_config->name) != (len)); \ + if (!intel_compare_buffer(current_config->name, pipe_config->name, (len))) { \ + pipe_config_buffer_mismatch(dev_priv, fastset, __stringify(name), \ + current_config->name, \ + pipe_config->name, \ + (len)); \ + ret = false; \ + } \ +} while (0) -:71: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'len' - possible side-effects? #71: FILE: drivers/gpu/drm/i915/display/intel_display.c:5734: +#define PIPE_CONF_CHECK_BUFFER(name, len) do { \ + BUILD_BUG_ON(sizeof(current_config->name) != (len)); \ + BUILD_BUG_ON(sizeof(pipe_config->name) != (len)); \ + if (!intel_compare_buffer(current_config->name, pipe_config->name, (len))) { \ + pipe_config_buffer_mismatch(dev_priv, fastset, __stringify(name), \ + current_config->name, \ + pipe_config->name, \ + (len)); \ + ret = false; \ + } \ +} while (0) total: 0 errors, 0 warnings, 3 checks, 67 lines checked 5863e4603212 drm/i915/audio: Include ELD in the state dump dcaf640d8e0b hax: drm/i915/audio: Make HSW hardware ELD buffer sort of work