Make sure we can always place an object at some GTT address, so
long as we adhere to the min GTT alignment for the given region.
Signed-off-by: Matthew Auld <matthew.auld@xxxxxxxxx>
Cc: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>
Cc: Nirmoy Das <nirmoy.das@xxxxxxxxx>
Reviewed-by: Nirmoy Das <nirmoy.das@xxxxxxxxx>
---
tests/i915/gem_create.c | 117 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 117 insertions(+)
diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
index becdc715..5ede76fa 100644
--- a/tests/i915/gem_create.c
+++ b/tests/i915/gem_create.c
@@ -821,6 +821,115 @@ static void create_ext_cpu_access_big(int fd)
free(regions);
}
+/** XXX: remove once we sync the uapi header */
+#define gtt_alignment rsvd0
+static bool supports_gtt_alignment(int fd)
+{
+ struct drm_i915_query_memory_regions *regions;
+ uint32_t gtt_alignment;
+
+ regions = gem_get_query_memory_regions(fd);
+ igt_assert(regions);
+ igt_assert(regions->num_regions);
+
+ gtt_alignment = regions->regions[0].gtt_alignment;
+ free(regions);
+
+ return gtt_alignment;
+}
+
+static void create_ext_placement_alignment(int fd)
+{
+ struct drm_i915_gem_create_ext_memory_regions setparam_region = {
+ .base = { .name = I915_GEM_CREATE_EXT_MEMORY_REGIONS },
+ };
+ struct drm_i915_gem_memory_class_instance *uregions;
+ struct drm_i915_query_memory_regions *regions;
+ const uint32_t bbe = MI_BATCH_BUFFER_END;
+ struct drm_i915_gem_execbuffer2 execbuf = {};
+ struct drm_i915_gem_exec_object2 obj = {};
+ uint32_t max_gtt_alignment;
+ uint32_t handle;
+ uint32_t ctx;
+ uint64_t ahnd;
+ uint64_t size;
+ int i;
+
+ regions = gem_get_query_memory_regions(fd);
+ igt_assert(regions);
+ igt_assert(regions->num_regions);
+
+ uregions = calloc(regions->num_regions, sizeof(*uregions));
+
+ ctx = gem_context_create(fd);
+
+ max_gtt_alignment = 0;
+ for (i = 0; i < regions->num_regions; i++) {
+ struct drm_i915_memory_region_info qmr = regions->regions[i];
+ struct drm_i915_gem_memory_class_instance ci = qmr.region;
+ uint32_t gtt_alignment;
+
+ gtt_alignment = qmr.gtt_alignment;
+
+ setparam_region.regions = to_user_pointer(&ci);
+ setparam_region.num_regions = 1;
+
+ size = PAGE_SIZE;
+ igt_assert_eq(__gem_create_ext(fd, &size, 0, &handle,
+ &setparam_region.base), 0);
+ gem_write(fd, handle, 0, &bbe, sizeof(bbe));
+
+ ahnd = intel_allocator_open_full(fd, ctx, 0, 0,
+ INTEL_ALLOCATOR_RANDOM,
+ ALLOC_STRATEGY_HIGH_TO_LOW,
+ gtt_alignment);
+
+ obj.handle = handle;
+ obj.offset = CANONICAL(get_offset(ahnd, handle, size, 0));
+ obj.flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS | EXEC_OBJECT_PINNED;
+
+ execbuf.buffers_ptr = to_user_pointer(&obj);
+ execbuf.buffer_count = 1;
+
+ gem_execbuf(fd, &execbuf);
+
+ put_ahnd(ahnd);
+
+ max_gtt_alignment = max(max_gtt_alignment, gtt_alignment);
+ uregions[i] = regions->regions[i].region;
+ }
+
+ setparam_region.regions = to_user_pointer(uregions);
+ setparam_region.num_regions = regions->num_regions;
+
+ size = PAGE_SIZE;
+ igt_assert_eq(__gem_create_ext(fd, &size, 0, &handle,
+ &setparam_region.base), 0);
+ gem_write(fd, handle, 0, &bbe, sizeof(bbe));
+
+ ahnd = intel_allocator_open_full(fd, ctx, 0, 0,
+ INTEL_ALLOCATOR_RANDOM,
+ ALLOC_STRATEGY_HIGH_TO_LOW,
+ max_gtt_alignment);
+
+ obj.handle = handle;
+ obj.offset = CANONICAL(get_offset(ahnd, handle, size, 0));
+ obj.flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS | EXEC_OBJECT_PINNED;
+
+ execbuf.buffers_ptr = to_user_pointer(&obj);
+ execbuf.buffer_count = 1;
+
+ gem_execbuf(fd, &execbuf);
+
+ put_ahnd(ahnd);
+
+ gem_context_destroy(fd, ctx);
+
+ gem_close(fd, handle);
+ free(uregions);
+ free(regions);
+}
+
igt_main
{
int fd = -1;
@@ -906,4 +1015,12 @@ igt_main
igt_require(supports_needs_cpu_access(fd));
create_ext_cpu_access_big(fd);
}
+
+ igt_describe("Check reported GTT alignment gives usable GTT address, for each region.");
+ igt_subtest("create-ext-placement-alignment") {
+ igt_require(supports_gtt_alignment(fd));
+ igt_require(gem_uses_full_ppgtt(fd));
+ create_ext_placement_alignment(fd);
+ }
+
}
--
2.37.3
