Hi Andrzej, [...] > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index 2595ec5aeb77f6..c07c97f4036abd 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -885,38 +885,28 @@ static void pnv_update_wm(struct drm_i915_private *dev_priv) > wm = intel_calculate_wm(pixel_rate, &pnv_display_wm, > pnv_display_wm.fifo_size, > cpp, latency->display_sr); > - reg = intel_uncore_read(&dev_priv->uncore, DSPFW1); > - reg &= ~DSPFW_SR_MASK; > - reg |= FW_WM(wm, SR); > - intel_uncore_write(&dev_priv->uncore, DSPFW1, reg); > + intel_uncore_rmw(&dev_priv->uncore, DSPFW1, DSPFW_SR_MASK, FW_WM(wm, SR)); any chance to break these lines in 80 characters? (valid for the rest of the lines) Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> Andi
