Re: [PATCH 1/1] drm/i915/guc: Fix GuC error capture sizing estimation and reporting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I disagree because its unlikely that all engines can reset all at once (we probably have bigger problems at the at
point) and if they all occurred within the same G2H handler scheduled worker run, our current gpu_coredump framework
would just discard the ones after the first one and so it wouldnt even matter if we did catch it.

But I'll go ahead and re-rev this.
...alan

On Fri, 2022-09-30 at 10:48 -0700, Harrison, John C wrote:
> Isn't min_size the bare minimum to get a valid capture? Surely this 
> still needs to be a warning not a debug. If we can't manage a basic 
> working error capture then there is a problem. This needs to be caught 
> by CI and logged as a bug if it is ever hit. And that means an end user 
> should never see it fire because we won't let a driver out the door 
> unless the default buffer size is sufficient.





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux