On Tue, 27 Sep 2022, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Stop considering VBT's static DRRS support when deciding whether > to use alternate fixed modes or not. It looks like Windows more > or less just uses that to decide whether to automagically switch > refresh rates on AC<->batter changes, or perhaps whether to *battery The series is Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> > even expose a control for that in some UI thing. Either way it > seems happy to always use all EDID modes, and I guess the > DRRS/VRR stuff more or less adjust how said modes get > actually used. > > Let's do the same and just accept all the suitable looking > modes from EDID, whether we have DRRS or VRR. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6323 > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6484 > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index c368caa23291..70b06806ec0d 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -5292,9 +5292,7 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp, > intel_bios_init_panel(dev_priv, &intel_connector->panel, > encoder->devdata, IS_ERR(edid) ? NULL : edid); > > - intel_panel_add_edid_fixed_modes(intel_connector, > - intel_connector->panel.vbt.drrs_type != DRRS_TYPE_NONE || > - intel_vrr_is_capable(intel_connector)); > + intel_panel_add_edid_fixed_modes(intel_connector, true); > > /* MSO requires information from the EDID */ > intel_edp_mso_init(intel_dp); -- Jani Nikula, Intel Open Source Graphics Center
