== Series Details == Series: drm/i915: Start cleaning up the DPLL ID mess (rev2) URL : https://patchwork.freedesktop.org/series/108827/ State : warning == Summary == Error: dim checkpatch failed 490086d775df drm/i915: Stop requiring PLL index == PLL ID -:172: CHECK:SPACING: No space is necessary after a cast #172: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:538: + id = (enum intel_dpll_id) crtc->pipe; total: 0 errors, 0 warnings, 1 checks, 196 lines checked 15d742afc5e2 drm/i915: Decouple I915_NUM_PLLS from PLL IDs 89dba9f4cb15 drm/i915: Introduce for_each_shared_dpll() -:161: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #161: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.h:39: +#define for_each_shared_dpll(__i915, __pll, __i) \ + for ((__i) = 0; (__i) < (__i915)->display.dpll.num_shared_dpll && \ + ((__pll) = &(__i915)->display.dpll.shared_dplls[(__i)]); (__i)++) -:161: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects? #161: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.h:39: +#define for_each_shared_dpll(__i915, __pll, __i) \ + for ((__i) = 0; (__i) < (__i915)->display.dpll.num_shared_dpll && \ + ((__pll) = &(__i915)->display.dpll.shared_dplls[(__i)]); (__i)++) total: 0 errors, 0 warnings, 2 checks, 142 lines checked d8e137cbf543 drm/i915: s/dev_priv/i915/ in the shared_dpll code -:98: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!pll" #98: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:230: + if (drm_WARN_ON(&i915->drm, pll == NULL)) total: 0 errors, 0 warnings, 1 checks, 2184 lines checked
