On Fri, 23 Sep 2022 13:11:44 -0700, Umesh Nerlige Ramappa wrote: > > XEHPSDV and DG2 provide a way to configure bytes per clock vs commands > per clock reporting. Enable bytes per clock setting on enabling OA. The commit title should also be changed to say bytes per clock instead of commands per clock. Also please add "Bspec: 51762" (and also maybe "Bspec: 52201") to the commit message. > @@ -2760,6 +2762,16 @@ gen12_enable_metric_set(struct i915_perf_stream *stream, > (period_exponent << GEN12_OAG_OAGLBCTXCTRL_TIMER_PERIOD_SHIFT)) > : 0); > > + /* > + * Initialize Super Queue Internal Cnt Register > + * Set PMON Enable in order to collect valid metrics. > + * Enable commands per clock reporting in OA for XEHPSDV onward. Here also say bytes per clock instead of commands per clock. > + */ > + sqcnt1 = GEN12_SQCNT1_PMON_ENABLE | > + (HAS_OA_BPC_REPORTING(i915) ? GEN12_SQCNT1_OABPC : 0); > + > + intel_uncore_rmw(uncore, GEN12_SQCNT1, 0, sqcnt1); > + With that, this patch is: Reviewed-by: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx>
