Re: [PATCH v2 1/1] drm/i915/pxp: Add firmware status when ARB session fails

[Juston Li <justonli@xxxxxxxxxxxx>]

On Thu, Sep 22, 2022 at 11:44 PM Alan Previn
<alan.previn.teres.alexis@xxxxxxxxx> wrote:
>
> Add firmware status using a drm_warn when ARB session fails
> or else a drm_dbg when the ARB session register slot bit did
> get set.
>
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 1 +
>  drivers/gpu/drm/i915/pxp/intel_pxp_tee.c     | 3 +++
>  2 files changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_session.c b/drivers/gpu/drm/i915/pxp/intel_pxp_session.c
> index 1bb5b5249157..c4f5c994ca51 100644
> --- a/drivers/gpu/drm/i915/pxp/intel_pxp_session.c
> +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_session.c
> @@ -77,6 +77,7 @@ static int pxp_create_arb_session(struct intel_pxp *pxp)
>                 drm_err(&gt->i915->drm, "arb session failed to go in play\n");
>                 return ret;
>         }
> +       drm_dbg(&gt->i915->drm, "PXP ARB session is alive\n");
>
>         if (!++pxp->key_instance)
>                 ++pxp->key_instance;
> diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c
> index 4b6f5655fab5..a90905039216 100644
> --- a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c
> +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c
> @@ -174,6 +174,9 @@ int intel_pxp_tee_cmd_create_arb_session(struct intel_pxp *pxp,
>
>         if (ret)
>                 drm_err(&i915->drm, "Failed to send tee msg ret=[%d]\n", ret);
> +       else if (msg_out.header.status != 0x0)
> +               drm_warn(&i915->drm, "PXP firmware failed arb session init request ret=[0x%08x]\n",
> +                        msg_out.header.status);
>
>         return ret;
>  }
> --
> 2.25.1
>

Reviewed-by: Juston Li <justonli@xxxxxxxxxxxx>