Re: [PATCH v1 2/3] drm/i915/gt: Extract per-platform function for frequency read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 13, 2022 at 08:17:02AM -0300, Gustavo Sousa wrote:
Hi, Lucas.

On Thu, Sep 08, 2022 at 01:08:15PM -0700, Lucas De Marchi wrote:
Instead of calling read_clock_frequency() to walk the if/else ladder
per platform, move the ladder to intel_gt_init_clock_frequency() and
use one function per branch.

I think the split of current code into separate functions looks good. However,
maybe the correct place to do that would be inside read_clock_frequency()
instead of intel_gt_init_clock_frequency(), since read_clock_frequency() is used
inside intel_gt_check_clock_frequency().

indeed, good catch. I forgot about the debug thing reading it again
later.

thanks
Lucas De Marchi



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux