On Thu, Sep 01, 2022 at 11:30:56AM +0530, Ankit Nautiyal wrote: > The decision to use DFP output format conversion capabilities should be > during compute_config phase. > > This patch adds new members to crtc_state to help configure the DFP > output related conversions. Also adds a member to intel_dp to store > ycbcr420 pass through capability. > > This will help to store only the format conversion capabilities of the > DP device in intel_dp->dfp, and use crtc_state to compute and store the > configuration for color/format conversion for a given mode. > > Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_display_types.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h > index 0da9b208d56e..065ed19a5dd3 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_types.h > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h > @@ -1311,6 +1311,12 @@ struct intel_crtc_state { > > /* for loading single buffered registers during vblank */ > struct drm_vblank_work vblank_work; > + > + /* DP DFP color configuration */ > + struct { > + bool rgb_to_ycbcr; > + bool ycbcr_444_to_420; > + } dp_dfp_config; Hmm. I'm thinking just something like enum intel_output_format sink_format; might be easier to deal with. > }; > > enum intel_pipe_crc_source { > @@ -1704,6 +1710,7 @@ struct intel_dp { > int pcon_max_frl_bw; > u8 max_bpc; > bool ycbcr_444_to_420; > + bool ycbcr420_passthrough; > bool rgb_to_ycbcr; > } dfp; > > -- > 2.25.1 -- Ville Syrjälä Intel