On Wed, Sep 07, 2022 at 01:26:06PM -0700, Lucas De Marchi wrote:
> This reverts commit 487970e8bb776c989013bb59d6cbb22e45b9afc6.
>
> Updated bspec and workaround database note Wa_1409120013 is not needed
> for DG2 (or any Display 13) platform.
This should probably say "Xe_LPD" to use standard terminology.
>
> Cc: Matt Roper <matthew.d.roper@xxxxxxxxx>
> Cc: Matt Atwood <matthew.s.atwood@xxxxxxxxx>
> Cc: Clint Taylor <Clinton.A.Taylor@xxxxxxxxx>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 210c1f78cc90..6ff0b80e69ac 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -7614,9 +7614,9 @@ static void icl_init_clock_gating(struct drm_i915_private *dev_priv)
>
> static void gen12lp_init_clock_gating(struct drm_i915_private *dev_priv)
> {
> - /* Wa_1409120013:tgl,rkl,adl-s,dg1,dg2 */
> + /* Wa_1409120013:tgl,rkl,adl-s,dg1 */
When adding new workarounds lately I've been dropping the platform
trailers since it's obvious enough from the next few lines of code (and
it's easy for the comments to get out of sync with the code). I'd be
tempted to just shorten this to "/* Wa_1409120013 */" but up to you.
> if (IS_TIGERLAKE(dev_priv) || IS_ROCKETLAKE(dev_priv) ||
> - IS_ALDERLAKE_S(dev_priv) || IS_DG1(dev_priv) || IS_DG2(dev_priv))
> + IS_ALDERLAKE_S(dev_priv) || IS_DG1(dev_priv))
We could also go with
if (DISPLAY_VER(dev_priv) == 12)
to simplify.
Anway, both of the code suggestions are optional; up to you whether you
think they're worth incorporating or not.
Reviewed-by: Matt Roper <matthew.d.roper@xxxxxxxxx>
with the small commit message tweak.
Matt
> intel_uncore_write(&dev_priv->uncore, ILK_DPFC_CHICKEN(INTEL_FBC_A),
> DPFC_CHICKEN_COMP_DUMMY_PIXEL);
>
> --
> 2.37.2
>
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
