Re: [PATCH v8 13/16] mei: drop ready bits check after start

["Ceraolo Spurio, Daniele" <daniele.ceraolospurio@xxxxxxxxx>]

On 9/7/2022 8:58 AM, Tomas Winkler wrote:
> From: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>
>
> The check that hardware and host ready bits are set after start
> is redundant and may fail and disable driver if there is
> back-to-back link reset issued right after start.
> This happens during pxp mode transitions when firmware
> undergo reset. Remove these checks to eliminate such failures.
>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>
> Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>

Daniele

> ---
>   drivers/misc/mei/init.c | 10 ----------
>   1 file changed, 10 deletions(-)
>
> diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c
> index 1b4d5d7870b9..bac8852aad51 100644
> --- a/drivers/misc/mei/init.c
> +++ b/drivers/misc/mei/init.c
> @@ -218,16 +218,6 @@ int mei_start(struct mei_device *dev)
>   		goto err;
>   	}
>   
> -	if (!mei_host_is_ready(dev)) {
> -		dev_err(dev->dev, "host is not ready.\n");
> -		goto err;
> -	}
> -
> -	if (!mei_hw_is_ready(dev)) {
> -		dev_err(dev->dev, "ME is not ready.\n");
> -		goto err;
> -	}
> -
>   	if (!mei_hbm_version_is_supported(dev)) {
>   		dev_dbg(dev->dev, "MEI start failed.\n");
>   		goto err;