On Tue, Sep 06, 2022 at 10:04:32PM +0200, Jernej Škrabec wrote: > Dne ponedeljek, 29. avgust 2022 ob 15:11:50 CEST je Maxime Ripard napisal(a): > > Our mode_set implementation can be merged into our atomic_enable > > implementation to simplify things, so let's do this. > > Are you sure this is a good thing in long term? What if user wants to change > mode? Unlikely, but why not. It doesn't change anything feature-wise: whenever the mode is changed on the CRTC, the encoder is going to be disabled and enabled. It's disabled here: https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_atomic_helper.c#L1064 And enabled here: https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_atomic_helper.c#L1403 With drm_atomic_crtc_needs_modeset() being defined here: https://elixir.bootlin.com/linux/latest/source/include/drm/drm_atomic.h#L1049 Maxime
Attachment:
signature.asc
Description: PGP signature
