On Fri, 15 Jul 2022, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> Add a few comment documenting the sets of bits in the driver
> features block. Might make it a bit easier to check against
> the spec.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> index 8bdb533b5304..c04937aa75b2 100644
> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> @@ -542,6 +542,7 @@ struct bdb_psr {
> #define BDB_DRIVER_FEATURE_INT_SDVO_LVDS 3
>
> struct bdb_driver_features {
> + /* Driver bits */
> u8 boot_dev_algorithm:1;
> u8 block_display_switch:1;
> u8 allow_display_switch:1;
> @@ -556,6 +557,7 @@ struct bdb_driver_features {
> u8 boot_mode_bpp;
> u8 boot_mode_refresh;
>
> + /* Extended Driver Bits 1 */
> u16 enable_lfp_primary:1;
> u16 selective_mode_pruning:1;
> u16 dual_frequency:1;
> @@ -571,6 +573,7 @@ struct bdb_driver_features {
> u16 tv_hotplug:1;
> u16 hdmi_config:2;
>
> + /* Driver Flags 1 */
> u8 static_display:1; /* 163+ */
> u8 reserved2:7;
>
> @@ -578,8 +581,12 @@ struct bdb_driver_features {
> u16 legacy_crt_max_y;
> u8 legacy_crt_max_refresh;
>
> + /* Extended Driver Bits 2 */
> u8 hdmi_termination;
> +
> u8 custom_vbt_version; /* 165+ */
> +
> + /* Driver Feature Flags */
> u16 rmpm_enabled:1; /* 165+ */
> u16 s2ddt_enabled:1; /* 165+ */
> u16 dpst_enabled:1; /* 165-227 */
--
Jani Nikula, Intel Open Source Graphics Center
