On Sat, 27 Aug 2022, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Since we only use the parsed vrefresh range to determine > if VRR should be supported we should only accept continuous > frequency displays here. > > Cc: Manasi Navare <manasi.d.navare@xxxxxxxxx> > Cc: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx> > Cc: Harry Wentland <harry.wentland@xxxxxxx> > Cc: Leo Li <sunpeng.li@xxxxxxx> > Cc: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx> > Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Makes sense, at least for sane EDIDs. :p Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> > --- > drivers/gpu/drm/drm_edid.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 856d304a1354..b459fdf12b58 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -6064,7 +6064,10 @@ static void drm_get_vrr_range(struct drm_connector *connector, > .drm_edid = drm_edid, > }; > > - if (!version_greater(drm_edid, 1, 1)) > + if (!version_greater(drm_edid, 1, 3)) > + return; > + > + if (!(drm_edid->edid->features & DRM_EDID_FEATURE_CONTINUOUS_FREQ)) > return; > > drm_for_each_detailed_block(drm_edid, get_vrr_range, &closure); -- Jani Nikula, Intel Open Source Graphics Center