== Series Details == Series: drm/i915: HuC loading for DG2 (rev2) URL : https://patchwork.freedesktop.org/series/107477/ State : warning == Summary == Error: dim checkpatch failed 999ceb6717f1 HAX: mei: GSC support for XeHP SDV and DG2 platform Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in <module> from ply import lex, yacc ModuleNotFoundError: No module named 'ply' -:518: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #518: FILE: drivers/misc/mei/debugfs.c:91: +#define MEI_PXP_MODE(state) case MEI_DEV_PXP_##state: return #state -:1286: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #1286: new file mode 100644 total: 1 errors, 1 warnings, 0 checks, 1216 lines checked 8be6e362a15f mei: add support to GSC extended header b46491433513 mei: bus: enable sending gsc commands 32f07199db10 mei: bus: extend bus API to support command streamer API 18f6af8db885 mei: pxp: add command streamer API to the PXP driver -:11: WARNING:REPEATED_WORD: Possible repeated word: 'just' #11: just just a thin wrapper around mei_cldev_send_gsc_command() total: 0 errors, 1 warnings, 0 checks, 55 lines checked 8a1b526ca63e mei: pxp: support matching with a gfx discrete card 590009d85aed drm/i915/pxp: load the pxp module when we have a gsc-loaded huc e4a63dc95553 drm/i915/pxp: implement function for sending tee stream command 3f995ae33b0c drm/i915/pxp: add huc authentication and loading command Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in <module> from ply import lex, yacc ModuleNotFoundError: No module named 'ply' Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in <module> from ply import lex, yacc ModuleNotFoundError: No module named 'ply' -:29: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 126 lines checked 624e3db5a5fc drm/i915/dg2: setup HuC loading via GSC -:6: WARNING:TYPO_SPELLING: 'teh' may be misspelled - perhaps 'the'? #6: The GSC will perform both the load and teh authentication, so we just ^^^ -:42: ERROR:SPACING: space required after that ',' (ctx:VxV) #42: FILE: drivers/gpu/drm/i915/gt/uc/intel_huc.c:140: + drm_err(>->i915->drm,"HuC: Firmware not verified %d\n", ret); ^ total: 1 errors, 1 warnings, 0 checks, 173 lines checked 69d35acbc642 drm/i915/huc: track delayed HuC load with a fence -:219: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '&intf->adev->aux_dev.dev != dev' #219: FILE: drivers/gpu/drm/i915/gt/uc/intel_huc.c:158: + if (!intf->adev || (&intf->adev->aux_dev.dev != dev)) total: 0 errors, 0 warnings, 1 checks, 326 lines checked 8dc90361a267 drm/i915/huc: stall media submission until HuC is loaded 458c9c847545 drm/i915/huc: better define HuC status getparam possible return values. 146893fe12c7 drm/i915/huc: define gsc-compatible HuC fw for DG2 -:43: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #43: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:77: +#define INTEL_HUC_FIRMWARE_DEFS(fw_def, huc_dma_def, huc_gsc_def) \ + fw_def(DG2, 0, huc_gsc_def(dg2, 7, 10, 0)) \ + fw_def(ALDERLAKE_P, 0, huc_dma_def(tgl, 7, 9, 3)) \ + fw_def(ALDERLAKE_S, 0, huc_dma_def(tgl, 7, 9, 3)) \ + fw_def(DG1, 0, huc_dma_def(dg1, 7, 9, 3)) \ + fw_def(ROCKETLAKE, 0, huc_dma_def(tgl, 7, 9, 3)) \ + fw_def(TIGERLAKE, 0, huc_dma_def(tgl, 7, 9, 3)) \ + fw_def(JASPERLAKE, 0, huc_dma_def(ehl, 9, 0, 0)) \ + fw_def(ELKHARTLAKE, 0, huc_dma_def(ehl, 9, 0, 0)) \ + fw_def(ICELAKE, 0, huc_dma_def(icl, 9, 0, 0)) \ + fw_def(COMETLAKE, 5, huc_dma_def(cml, 4, 0, 0)) \ + fw_def(COMETLAKE, 0, huc_dma_def(kbl, 4, 0, 0)) \ + fw_def(COFFEELAKE, 0, huc_dma_def(kbl, 4, 0, 0)) \ + fw_def(GEMINILAKE, 0, huc_dma_def(glk, 4, 0, 0)) \ + fw_def(KABYLAKE, 0, huc_dma_def(kbl, 4, 0, 0)) \ + fw_def(BROXTON, 0, huc_dma_def(bxt, 2, 0, 0)) \ + fw_def(SKYLAKE, 0, huc_dma_def(skl, 2, 0, 0)) -:43: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fw_def' - possible side-effects? #43: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:77: +#define INTEL_HUC_FIRMWARE_DEFS(fw_def, huc_dma_def, huc_gsc_def) \ + fw_def(DG2, 0, huc_gsc_def(dg2, 7, 10, 0)) \ + fw_def(ALDERLAKE_P, 0, huc_dma_def(tgl, 7, 9, 3)) \ + fw_def(ALDERLAKE_S, 0, huc_dma_def(tgl, 7, 9, 3)) \ + fw_def(DG1, 0, huc_dma_def(dg1, 7, 9, 3)) \ + fw_def(ROCKETLAKE, 0, huc_dma_def(tgl, 7, 9, 3)) \ + fw_def(TIGERLAKE, 0, huc_dma_def(tgl, 7, 9, 3)) \ + fw_def(JASPERLAKE, 0, huc_dma_def(ehl, 9, 0, 0)) \ + fw_def(ELKHARTLAKE, 0, huc_dma_def(ehl, 9, 0, 0)) \ + fw_def(ICELAKE, 0, huc_dma_def(icl, 9, 0, 0)) \ + fw_def(COMETLAKE, 5, huc_dma_def(cml, 4, 0, 0)) \ + fw_def(COMETLAKE, 0, huc_dma_def(kbl, 4, 0, 0)) \ + fw_def(COFFEELAKE, 0, huc_dma_def(kbl, 4, 0, 0)) \ + fw_def(GEMINILAKE, 0, huc_dma_def(glk, 4, 0, 0)) \ + fw_def(KABYLAKE, 0, huc_dma_def(kbl, 4, 0, 0)) \ + fw_def(BROXTON, 0, huc_dma_def(bxt, 2, 0, 0)) \ + fw_def(SKYLAKE, 0, huc_dma_def(skl, 2, 0, 0)) -:43: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'huc_dma_def' - possible side-effects? #43: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:77: +#define INTEL_HUC_FIRMWARE_DEFS(fw_def, huc_dma_def, huc_gsc_def) \ + fw_def(DG2, 0, huc_gsc_def(dg2, 7, 10, 0)) \ + fw_def(ALDERLAKE_P, 0, huc_dma_def(tgl, 7, 9, 3)) \ + fw_def(ALDERLAKE_S, 0, huc_dma_def(tgl, 7, 9, 3)) \ + fw_def(DG1, 0, huc_dma_def(dg1, 7, 9, 3)) \ + fw_def(ROCKETLAKE, 0, huc_dma_def(tgl, 7, 9, 3)) \ + fw_def(TIGERLAKE, 0, huc_dma_def(tgl, 7, 9, 3)) \ + fw_def(JASPERLAKE, 0, huc_dma_def(ehl, 9, 0, 0)) \ + fw_def(ELKHARTLAKE, 0, huc_dma_def(ehl, 9, 0, 0)) \ + fw_def(ICELAKE, 0, huc_dma_def(icl, 9, 0, 0)) \ + fw_def(COMETLAKE, 5, huc_dma_def(cml, 4, 0, 0)) \ + fw_def(COMETLAKE, 0, huc_dma_def(kbl, 4, 0, 0)) \ + fw_def(COFFEELAKE, 0, huc_dma_def(kbl, 4, 0, 0)) \ + fw_def(GEMINILAKE, 0, huc_dma_def(glk, 4, 0, 0)) \ + fw_def(KABYLAKE, 0, huc_dma_def(kbl, 4, 0, 0)) \ + fw_def(BROXTON, 0, huc_dma_def(bxt, 2, 0, 0)) \ + fw_def(SKYLAKE, 0, huc_dma_def(skl, 2, 0, 0)) -:112: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'major_' - possible side-effects? #112: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:138: +#define HUC_GSC_FW_BLOB(prefix_, major_, minor_, bld_num_) \ + UC_FW_BLOB(major_, minor_, true, \ + MAKE_HUC_GSC_FW_PATH(prefix_, major_, minor_, bld_num_)) -:112: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'minor_' - possible side-effects? #112: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:138: +#define HUC_GSC_FW_BLOB(prefix_, major_, minor_, bld_num_) \ + UC_FW_BLOB(major_, minor_, true, \ + MAKE_HUC_GSC_FW_PATH(prefix_, major_, minor_, bld_num_)) total: 1 errors, 0 warnings, 4 checks, 111 lines checked fbc9125edc5a HAX: drm/i915: force INTEL_MEI_GSC and INTEL_MEI_PXP on for CI
