✗ Fi.CI.CHECKPATCH: warning for i915-pmu: Add extra check engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: i915-pmu: Add extra check engine
URL   : https://patchwork.freedesktop.org/series/107328/
State : warning

== Summary ==

Error: dim checkpatch failed
8b3861fad72f i915-pmu: Add extra check engine
-:6: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#6: 
Return value of a function 'intel_engine_lookup_user' is dereferenced at i915_pmu.c:708

-:23: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "engine"
#23: FILE: drivers/gpu/drm/i915/i915_pmu.c:730:
+		if (engine != NULL) {

-:24: ERROR:CODE_INDENT: code indent should use tabs where possible
#24: FILE: drivers/gpu/drm/i915/i915_pmu.c:731:
+^I^I        if (--engine->pmu.enable_count[sample] == 0)$

-:25: ERROR:CODE_INDENT: code indent should use tabs where possible
#25: FILE: drivers/gpu/drm/i915/i915_pmu.c:732:
+^I^I^I        engine->pmu.enable &= ~BIT(sample);$

total: 2 errors, 1 warnings, 1 checks, 12 lines checked





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux