> -----Original Message----- > From: Nikula, Jani <jani.nikula@xxxxxxxxx> > Sent: Tuesday, August 16, 2022 1:32 PM > To: Murthy, Arun R <arun.r.murthy@xxxxxxxxx>; intel- > gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: De Marchi, Lucas <lucas.demarchi@xxxxxxxxx> > Subject: RE: [PATCH 12/39] drm/i915: move and split audio under > display.audio and display.funcs > > On Tue, 16 Aug 2022, "Murthy, Arun R" <arun.r.murthy@xxxxxxxxx> wrote: > >> -----Original Message----- > >> From: Nikula, Jani <jani.nikula@xxxxxxxxx> > >> Sent: Friday, August 12, 2022 12:33 PM > >> To: Murthy, Arun R <arun.r.murthy@xxxxxxxxx>; intel- > >> gfx@xxxxxxxxxxxxxxxxxxxxx > >> Cc: De Marchi, Lucas <lucas.demarchi@xxxxxxxxx> > >> Subject: RE: [PATCH 12/39] drm/i915: move and split audio > >> under display.audio and display.funcs > >> > >> On Fri, 12 Aug 2022, "Murthy, Arun R" <arun.r.murthy@xxxxxxxxx> wrote: > >> >> -----Original Message----- > >> >> From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On > >> >> Behalf Of Jani Nikula > >> >> Sent: Thursday, August 11, 2022 8:37 PM > >> >> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > >> >> Cc: Nikula, Jani <jani.nikula@xxxxxxxxx>; De Marchi, Lucas > >> >> <lucas.demarchi@xxxxxxxxx> > >> >> Subject: [PATCH 12/39] drm/i915: move and split audio > >> >> under display.audio and display.funcs > >> >> > >> >> Move display related members under drm_i915_private display sub- > >> struct. > >> >> > >> >> Split audio funcs to display.funcs to follow the same pattern as > >> >> all the other display functions. > >> >> > >> > Audio is a feature as such so wouldn't intel_audio struct stand > >> > parallel to > >> intel_display? > >> > >> For i915, audio doesn't exist other than as a display feature. > >> Display is a higher level split here, parallel to gt/gem. > >> > > Will leave it to you, since you have started this huger series containing the > cleanup and understand you also have some more cleanup in queue. > > My small suggestion is not to mix audio with display and let this audi reside > in i915_priv and let it leave in parallel similar to gt/gem. > > No, I'm going to stick with this hierarchy. Audio is part of display here. > Reviewed-by: Arun R Murthy <arun.r.murthy@xxxxxxxxx> Thanks and Regards, Arun R Murthy --------------------
