On Fri, 12 Aug 2022, "Murthy, Arun R" <arun.r.murthy@xxxxxxxxx> wrote:
>> -----Original Message-----
>> From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Jani
>> Nikula
>> Sent: Thursday, August 11, 2022 8:37 PM
>> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
>> Cc: Nikula, Jani <jani.nikula@xxxxxxxxx>; De Marchi, Lucas
>> <lucas.demarchi@xxxxxxxxx>
>> Subject: [PATCH 11/39] drm/i915: move dmc to display.dmc
>>
>> Move display related members under drm_i915_private display sub-struct.
>>
>> FIXME: dmc really needs to be abstracted and hidden inside intel_dmc.c with
>> display.dmc turned into a pointer
>>
>> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>> ---
>> .../gpu/drm/i915/display/intel_display_core.h | 4 ++
>> .../drm/i915/display/intel_display_power.c | 18 +++----
>> .../i915/display/intel_display_power_well.c | 18 +++----
>> drivers/gpu/drm/i915/display/intel_dmc.c | 52 +++++++++----------
>> drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
>> drivers/gpu/drm/i915/i915_drv.h | 3 --
>> 6 files changed, 49 insertions(+), 48 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h
>> b/drivers/gpu/drm/i915/display/intel_display_core.h
>> index 030ced4068bb..ca22706e11e6 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_core.h
>> +++ b/drivers/gpu/drm/i915/display/intel_display_core.h
>> @@ -10,6 +10,7 @@
>> #include <linux/types.h>
>> #include <linux/wait.h>
>>
>> +#include "intel_dmc.h"
>> #include "intel_gmbus.h"
>>
>> struct drm_i915_private;
>> @@ -108,6 +109,9 @@ struct intel_display {
>> /* protects panel power sequencer state */
>> struct mutex mutex;
>> } pps;
>> +
>> + /* Grouping using named structs. Keep sorted. */
>> + struct intel_dmc dmc;
> Wouldn't it be better to skip this patch for now?
Why?
> Anyway the patch has a FIXME so can up with a proper patch later and avoid double work.
The FIXME is a long-term todo item, really, just logged it somewhere.
Basically this should be struct intel_dmc *dmc, struct intel_dmc should
be opaque and defined in intel_dmc.c. The patch at hand is really
trivial compared to that, and moves forward with the shorter term goal
of putting all the display stuff under i915->display.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
