> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Jani > Nikula > Sent: Thursday, August 11, 2022 8:37 PM > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Nikula, Jani <jani.nikula@xxxxxxxxx>; De Marchi, Lucas > <lucas.demarchi@xxxxxxxxx> > Subject: [PATCH 10/39] drm/i915: move and group pps members > under display.pps > > Move display related members under drm_i915_private display sub-struct. > > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> > --- > .../gpu/drm/i915/display/intel_display_core.h | 7 +++ > drivers/gpu/drm/i915/display/intel_pps.c | 48 +++++++++---------- > drivers/gpu/drm/i915/i915_driver.c | 2 +- > drivers/gpu/drm/i915/i915_drv.h | 5 -- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > 5 files changed, 33 insertions(+), 31 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h > b/drivers/gpu/drm/i915/display/intel_display_core.h > index fe19d4f9a9ab..030ced4068bb 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_core.h > +++ b/drivers/gpu/drm/i915/display/intel_display_core.h > @@ -101,6 +101,13 @@ struct intel_display { > > wait_queue_head_t wait_queue; > } gmbus; > + > + struct { > + u32 mmio_base; > + > + /* protects panel power sequencer state */ > + struct mutex mutex; > + } pps; > }; Again can this power related to be moved under a substruct intel_pm ? Thanks and Regards Arun R Murthy --------------------